Update paper to include suggestions by reviewer #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vivek Joshy <8206808+vivekjoshy@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 1774 1774
Branches 450 450
=========================================
Hits 1774 1774 ☔ View full report in Codecov by Sentry. |
|
@Naeemkh The new paper is available here: https://github.com/OpenDebates/openskill.py/actions/runs/6603401817 |
Signed-off-by: Vivek Joshy <8206808+vivekjoshy@users.noreply.github.com>
Signed-off-by: Vivek Joshy <8206808+vivekjoshy@users.noreply.github.com>
|
@matt-graham I've made the changes you requested for all the issues raised. The latest paper can be downloaded from here. |
Signed-off-by: Vivek Joshy <8206808+vivekjoshy@users.noreply.github.com>
openjournals/joss-reviews#5901 (comment) Signed-off-by: Vivek Joshy <8206808+vivekjoshy@users.noreply.github.com>
Signed-off-by: Vivek Joshy <8206808+vivekjoshy@users.noreply.github.com>
Signed-off-by: Vivek Joshy <8206808+vivekjoshy@users.noreply.github.com>
Signed-off-by: Vivek Joshy <8206808+vivekjoshy@users.noreply.github.com>
matt-graham
reviewed
Jan 5, 2024
matt-graham
reviewed
Jan 5, 2024
matt-graham
reviewed
Jan 5, 2024
matt-graham
reviewed
Jan 5, 2024
- Add ipywidgets to notebook. - Rerun the notebooks. - Update paper with latest benchmark results. - Add bibtex references for OpenSkill ports. Signed-off-by: Vivek Joshy <8206808+vivekjoshy@users.noreply.github.com>
Signed-off-by: Vivek Joshy <8206808+vivekjoshy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115 #122 #121 #120