Skip to content
This repository has been archived by the owner on Dec 20, 2021. It is now read-only.

Add "help" panel #686

Closed
gravestench opened this issue Aug 5, 2020 · 6 comments · Fixed by #724
Closed

Add "help" panel #686

gravestench opened this issue Aug 5, 2020 · 6 comments · Fixed by #724
Labels
Enhancement New feature or request Good First Issue Good for newcomers Normal Priority For issues that are essential, but are not on the critical path or blocking development in any way
Projects
OpenDiablo 2 Game Engine
Milestone
First Playable Alpha

Comments

@gravestench
Copy link
Contributor

Here it is from original diablo 2:
image

The keys displayed should reflect the current user keybindings
@gravestench gravestench added Enhancement New feature or request Good First Issue Good for newcomers labels Aug 5, 2020
@brendanporter
Copy link
Contributor

Largely addressed with #724

Still more work to be done. Close button doesn't have close behavior, and is missing icon.

@essial essial linked a pull request Sep 9, 2020 that will close this issue
Help Overlay Added #724
Merged
@essial essial reopened this Sep 9, 2020
@brendanporter
Copy link
Contributor

Added close button in PR #731
Font is still ugly on the close 0

@brendanporter
Copy link
Contributor

#739

Fixed close button appearance. That should be it for the basic overlay at this point.

@leahiel leahiel mentioned this issue Sep 26, 2020
Merged
@leahiel
Copy link
Contributor

leahiel commented Sep 26, 2020

#758 solved most of the remaining issues. Only two (known) issues remain:

Hotkeys should be reliant on the hotkeys used in game. However the "Configure Controls" panel #753 isn't done, so this cannot be done.
You can still click in the background while the help menu is open.

@joshjordan joshjordan mentioned this issue Oct 6, 2020
Merged
@joshjordan
Copy link
Contributor

The latter issue, "You can still click in the background while the help menu is open", up for PR

@gravestench gravestench mentioned this issue Oct 28, 2020
Closed
@gravestench gravestench added the Normal Priority For issues that are essential, but are not on the critical path or blocking development in any way label Oct 28, 2020
@gravestench gravestench added this to the First Playable Alpha milestone Oct 28, 2020
@gravestench gravestench added this to In progress in OpenDiablo 2 Game Engine Oct 28, 2020
@gucio321 gucio321 mentioned this issue Dec 14, 2020
Merged
@gucio321
Copy link
Contributor

It was solved in #972

OpenDiablo 2 Game Engine automation moved this from In progress to Done Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Enhancement New feature or request Good First Issue Good for newcomers Normal Priority For issues that are essential, but are not on the critical path or blocking development in any way
Projects
OpenDiablo 2 Game Engine
  
Done
Milestone
First Playable Alpha
Development

Successfully merging a pull request may close this issue.

Help Overlay Added
6 participants
@essial @joshjordan @gravestench @brendanporter @leahiel @gucio321