Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PDF reports while using split-merge #1227

Open
pierotofy opened this issue Jan 15, 2021 · 9 comments
Open

Add PDF reports while using split-merge #1227

pierotofy opened this issue Jan 15, 2021 · 9 comments

Comments

@pierotofy
Copy link
Member

Currently ODM does not generate PDF reports when using split-merge. It could be possible to generate them by:

  • Recomputing/aggregating stats from submodels
  • Write a new report generation code (separate from OpenSfM's)
@smathermather
Copy link
Contributor

smathermather commented Jan 15, 2021

I'd lean toward aggregate stats. Any reason to not have submodel stats as well? For larger datasets it could be more useful than global stats.

@pierotofy
Copy link
Member Author

I agree to both. The bottom line is that the split-merge report would contain slightly different information compared to normal runs.

@smathermather
Copy link
Contributor

Yup. Agreed.

@YanNoun
Copy link

YanNoun commented Jan 18, 2021

@pierotofy opensfm/action/compute_statistics.py calls stats.py functions that works on a list of reconstructions.

@pierotofy
Copy link
Member Author

Didn't know that. Thanks @YanNoun ! I'll try it out.

@YanNoun
Copy link

YanNoun commented Jan 18, 2021

The save_heatmap/save_topview might be super slow with 100K/1M points, feel free to run some random index-based decimation.

@pierotofy
Copy link
Member Author

I did notice some slowdowns with larger datasets; would this be a good idea for a PR to OpenSfM for the compute_statistics command? (I could add a --decimate flag)

@YanNoun
Copy link

YanNoun commented Jan 18, 2021

Yup definitely, that would be great !

@pierotofy
Copy link
Member Author

pierotofy commented Jan 18, 2021

mapillary/OpenSfM#695

I opted to allow a user to set a cap on the number of points using random sampling. Definitely helps keep runtime in check!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants