Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some beds are misplaced #243

Closed
Bertram25 opened this issue Oct 17, 2014 · 16 comments
Closed

Some beds are misplaced #243

Bertram25 opened this issue Oct 17, 2014 · 16 comments
Assignees
Milestone

Comments

@Bertram25
Copy link
Contributor

The Orc and Lizard beds are placed south of where they should be.
It might comes from two things. The bed has got either a wrong default orientation, or isn't centered on the 2 tiles:
odscreenshot_1413704495

The two beds models should be checked against the Bed.mesh one and get same alignment and default rotation value.
Could you do it, @Danimal696 ?
EDIT: The models are ok, the bug must be in the code.

@Danimal696
Copy link
Contributor

they were, i used the values of bed to center them

@Danimal696
Copy link
Contributor

did you set their values to be "BedDim 1/2" 1x2 on creature.def? this is how i see them in my game
new beds

@Bertram25
Copy link
Contributor Author

Ah ok. :) Then it seems the error doesn't come from the models. My apologies. :S

I'll give a screen shot asap.

@Bertram25
Copy link
Contributor Author

Here is an example of what is happening on my end:
odscreenshot_1413704495

@Danimal696
Copy link
Contributor

wierd ill upload my .def and you tell me

@Danimal696
Copy link
Contributor

i want a second opinion! could someone else besides Bertram confirm the same error?

http://forum.freegamedev.net/viewtopic.php?f=45&t=4765&p=60315#p60315

@Bertram25
Copy link
Contributor Author

This might also be a regression due to the new creature definition format. I'll have a look. :)

@Bertram25
Copy link
Contributor Author

@Danimal696 With the new rolling release out, could you tell me how beds do behave now? Thanks!

@Danimal696
Copy link
Contributor

they are still misplaced,
1x1 bed OK
1x2 bed the center in the same place as a 1x1
2x2 the center is in the same place as a 1x1 would be

@Danimal696
Copy link
Contributor

opendungeons 2014-11-03 18-21-32-038

@Bertram25
Copy link
Contributor Author

Thanks! This simple example really helps! :)

@hwoarangmy
Copy link
Contributor

I had seen that in the good way. Previously, creatures used to go at bottom left to sleep. Now, they go at center. I thought it was an improvement but it seems like it is a bug. I don't know when we introduced that (maybe while playing with the renderer ?) but I would say it comes from the beds being centered now.

@akien-mga
Copy link
Member

I would say it comes from the beds being centered now.

Judging from the screenshot, it seems the beds are centered on one tile, independently of the number of tiles that they are supposed to cover. Is it because they are placed on active spots?

@hwoarangmy
Copy link
Contributor

No, dormitory is a special room and active spots were never used there. Beds are on empty tiles. But when I look at the screenshot, I would say they are centered on the bottom left tile (where the creature used to sleep) instead of the center of their place.

@Danimal696
Copy link
Contributor

that the creature sleep at his center is good and something i would request on the future, but not in this way...

@Bertram25
Copy link
Contributor Author

What I have seen so far is that creatures getting a bed location are usually taking the most left-bottom one available, while the code is correcting the mesh location as if the tile chosen was forcefully the top-right one.

@hwoarangmy hwoarangmy self-assigned this Nov 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants