Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with screenRect vs bufferSize #191

Closed
clobber opened this issue Aug 9, 2012 · 1 comment
Closed

Bug with screenRect vs bufferSize #191

clobber opened this issue Aug 9, 2012 · 1 comment
Labels
Milestone

Comments

@clobber
Copy link
Member

clobber commented Aug 9, 2012

Currently both screenRect and bufferSize need to match up otherwise you'll get some distortion: http://cl.ly/image/0u1b0P2C0v39

For example, a "match" being OESizeMake(GPU_DISPLAY_WIDTH, GPU_DISPLAY_HEIGHT * 2) for the buffer and OERectMake(0, 0, GPU_DISPLAY_WIDTH, GPU_DISPLAY_HEIGHT * 2) for the screen.

Changing screenRect to OERectMake(0, 0, GPU_DISPLAY_WIDTH, GPU_DISPLAY_HEIGHT) will cause the wrong aspect ratio as seen in the screenshot above.

We should be able to change screenRect without having to adjust bufferSize. With git bisect I tracked down the problem to this commit which coincidentally was also to correct aspect ratio issues with resolution switching: 14a7279

@clobber
Copy link
Member Author

clobber commented Sep 6, 2012

Fixed here 0c58f6f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants