Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend] Add error message on FieldArray #383

Merged
merged 2 commits into from
Nov 6, 2023
Merged

[frontend] Add error message on FieldArray #383

merged 2 commits into from
Nov 6, 2023

Conversation

RomuDeuxfois
Copy link
Member

@RomuDeuxfois RomuDeuxfois linked an issue Nov 2, 2023 that may be closed by this pull request
Cannot update an POST inject in scenario tab #344
Closed
@RomuDeuxfois RomuDeuxfois added the filigran team use to identify PR from the Filigran team label Nov 3, 2023
@guillaumejparis
Copy link
Member

I do not remember, Do we prefer to use a Tootip component here ?

@RomuDeuxfois
Copy link
Member Author

I do not remember, Do we prefer to use a Tootip component here ?

I follow the MUI error field behavior
image

@RomuDeuxfois
Copy link
Member Author

PR ready for a second round

@RomuDeuxfois RomuDeuxfois merged commit 13971cc into master Nov 6, 2023
5 checks passed
@RomuDeuxfois RomuDeuxfois deleted the issue/344 branch November 6, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumejparis guillaumejparis guillaumejparis approved these changes

Assignees
No one assigned
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot update an POST inject in scenario tab
2 participants
@RomuDeuxfois @guillaumejparis