[all] update markdown lib #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumejparis
commented
Dec 6, 2023
Comment on lines
+61
to
+63
| { ...commands.codeEdit, buttonProps: { 'aria-label': 'code edit', title: 'code edit' } }, | ||
| { ...commands.codeLive, buttonProps: { 'aria-label': 'code live', title: 'code live' } }, | ||
| { ...commands.codePreview, buttonProps: { 'aria-label': 'code preview', title: 'code preview' } }, |
There was a problem hiding this comment.
missing translations
guillaumejparis
commented
Dec 6, 2023
| @@ -137,6 +137,55 @@ export default ( | |||
| fontSize: 12, | |||
| fontWeight: 400, | |||
| }, | |||
There was a problem hiding this comment.
delete react-mde styles
guillaumejparis
commented
Dec 6, 2023
| }, | ||
|
|
||
| optimizeDeps: { | ||
| include: [ | ||
| 'ckeditor5-custom-build/build/ckeditor', | ||
| ], | ||
| esbuildOptions: { |
There was a problem hiding this comment.
was causing bad interactions with new lib (and potentially others)
guillaumejparis
commented
Dec 6, 2023
| @@ -6,26 +6,27 @@ | |||
| "license": "Apache-2.0", | |||
There was a problem hiding this comment.
why not some more updates 💥
|
And some lint --fix (because of an lib update) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #452 +/- ##
=========================================
Coverage 15.58% 15.58%
Complexity 372 372
=========================================
Files 231 231
Lines 5005 5005
Branches 194 194
=========================================
Hits 780 780
Misses 4213 4213
Partials 12 12 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.