AMD, jQuery bundled #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduces number of exported global vars, and lays foundation for moving to AMD loader in future commits.
Not yet necessary. Left in combined js accidentally.
F2.js can be loaded as a standalone script file or via an AMD loader like requirejs, curl, dojo require, etc.
jQuery 1.8.3 is now bundled as part of F2.js. This removes need for containers to reference jQuery on their own. Also calls jQuery.noConflict() when done to allow multiple versions to coexist.
ghost
assigned 
|
Thanks, Ben. Great stuff. I'm doing some testing on the example containers and apps, and running into some script errors. I've got most of them tracked down and will add commits to this pull request. |
verified that the jquery instance inside of F2 contains modals and that the page can run a separate version of jquery and even no bootstrap at all
|
We are close to merging this pull request into |
Merged
|
This pull has been merged into 1.1-wip ahead of the 1.1 release. See #36 for specifics. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for F2.js to be loaded as an AMD module, or not. Also permits F2 to play more nicely within existing AMD containers. jQuery is also bundled as a dependency. Plus some fixes for Docs.
/cc @brianbaker @markhealey