A library should avoid calling printf, exit, abort, etc. (with review)

[semihalf-berestovskyy-andriy]

Note: the issue was created automatically with bugzilla2github tool

Bugzilla Bug ID: 56

Date: 2015-10-21 12:02:35 +0200
From: Sorin Vultureanu <sorin.vultureanu@enea.com>
To: Bogdan Pricope <bogdan.pricope@enea.com>
CC: bogdan.pricope@enea.com, ciprian.barbu@enea.com

Last updated: 2015-11-11 12:32:46 +0100

Bugzilla Comment ID: 70

Date: 2015-10-21 12:02:35 +0200
From: Sorin Vultureanu <sorin.vultureanu@enea.com>

Bugzilla Comment ID: 88

Date: 2015-11-02 14:32:52 +0100
From: Ciprian Barbu <ciprian.barbu@enea.com>

After reviewing the odp-fp code I think these should be looked at:

ofp_arp.c:477 - show_arp_entry effectively prints to stdout (fd=1), I think a log function should be used instead.

ofp_arp.c:650 - ofp_arp_alloc_shared_memory calls abort and exit
ofp_arp_ck.c:255 - same thing for ofp_arp_alloc_shared_memory

ofp_arp.c:668 - ofp_arp_lookup_shared_memory also calls abort and exit
ofp_arp_ck.c:272 - same thing

Bugzilla Comment ID: 98

Date: 2015-11-05 09:36:35 +0100
From: Sorin Vultureanu <sorin.vultureanu@enea.com>

*** Bug #55 has been marked as a duplicate of this bug. ***