Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we set the root cause of exception in metrics? #1882

Closed
chao-chang-paypay opened this issue Dec 15, 2022 · 1 comment · Fixed by #1883
Closed

Can we set the root cause of exception in metrics? #1882

chao-chang-paypay opened this issue Dec 15, 2022 · 1 comment · Fixed by #1883

Comments

@chao-chang-paypay
Copy link
Contributor

Setting the root cause(e.g. SocketTimeoutException ) as the tag value might be more helpful than the exception in feign layer(e.g. RetryableException)

tags.add(Tag.of("exception_name", e.getClass().getSimpleName()));

@velo
Copy link
Member

velo commented Dec 15, 2022

That makes a lot of sense, feel free to make a PR for this change.

Cheers,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants