Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging shows wrong HTTP protocol #2064

Open
FouquerYohann opened this issue May 26, 2023 · 2 comments
Open

Logging shows wrong HTTP protocol #2064

FouquerYohann opened this issue May 26, 2023 · 2 comments

Comments

@FouquerYohann
Copy link

In feign.SynchronousMethodHandler#executeAndDecode

The request constructor default to HTTP protocol 1.1
then it's logged
And only afterward the client execute changes it to protocol version 2.0

image

note : I'm using Http2Client but that should still be true for other clients

@vitalijr2
Copy link
Collaborator

vitalijr2 commented Jun 13, 2023

When the request was processed by the client, did the client update the protocol or is it the same?

It looks like an unrecoverable issue as the client shouldn't change the request object as it changes the protocol in its own conversation with a remote host.

@vitalijr2
Copy link
Collaborator

vitalijr2 commented Jun 20, 2023

There are two problems:

  • we cannot create a request with HTTP2 version[1],
  • we cannot update the request version to HTTP2[2].

Even if a client (Apache or java11) wants to update the version after it raised it in a physical dialogue with a server - it cannot do so.

We can set a real version in a response, e. g.

enumForName(Request.ProtocolVersion.class, httpResponse.getVersion().format()))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants