Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customize K Chart UI #23

Merged
merged 2 commits into from May 14, 2021
Merged

Customize K Chart UI #23

merged 2 commits into from May 14, 2021

Conversation

karanchuri
Copy link

What wasn't in the existing system?

  • Ability to customise UI of KChartWidget

What this PR solves?

  • In KChartWidget we will have to add ChartStyle and ChartColors object so that we can change it dynamically.

@mafanwei
Copy link
Collaborator

Thank you for your contribution.
Have you tested it yet?

@karanchuri
Copy link
Author

Yes, have tested with the line chart as well as ohlc graph.
Below is video url of my test with the line chart.
https://user-images.githubusercontent.com/29534520/117970252-149f5100-b346-11eb-99d5-bb9953827325.mp4

Also please note this is a major change as there are changes in KChartWidget required params.

@mafanwei
Copy link
Collaborator

Looks great.
I'll check it later.
Thank you for your contribution.

@mafanwei mafanwei merged commit d0faaac into OpenFlutter:master May 14, 2021
@karanchuri karanchuri deleted the feat/customize-k-chart-widget branch May 14, 2021 04:41
@karanchuri
Copy link
Author

Please update the flutter library in https://pub.dev/packages/k_chart

@mafanwei
Copy link
Collaborator

done

@karanchuri
Copy link
Author

Thanks ✌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@karanchuri @mafanwei