Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic function typeaheads aren't displaying properly in v0.7.x #1030

Closed
taylordowns2000 opened this issue Aug 16, 2023 · 2 comments · Fixed by #1065
Closed

Magic function typeaheads aren't displaying properly in v0.7.x #1030

taylordowns2000 opened this issue Aug 16, 2023 · 2 comments · Fixed by #1065
Assignees
Labels
bug Newly identified bug

Comments

@taylordowns2000
Copy link
Member

taylordowns2000 commented Aug 16, 2023

The typeahead boxes got thrown out of whack. See image here.

To replicate, set up a job with DHIS2 magic and start a typeahead for orgUnit: by pressing control + . You're no longer able to see the typeahead in its entirety.

image

For what it's worth, the enter-press still works as expected:
image


  • CSS of Monaco editor must be borked
  • Fix Monaco editor :P
@taylordowns2000 taylordowns2000 added bug Newly identified bug js/ts/tailwind-css labels Aug 16, 2023
@taylordowns2000
Copy link
Member Author

taylordowns2000 commented Aug 16, 2023

@josephjclark , @stuartc , something funky happened since we shifted to the modal Job Editor modal.

@mahaomolise92 , keeping you CCed here as well so you can see when this is fixed

@josephjclark
Copy link
Contributor

So the problem here is something do to with the editor being nested in the modal.

Googling around, the editor seems to struggle a bit when the editor is nested in a transformed or absolutely positioned container. Which seems a bit arbitrary really 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Newly identified bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants