Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have user create workflow name before moving to the canvas #1103

Closed
NickOpenFn opened this issue Sep 13, 2023 · 1 comment
Closed

Have user create workflow name before moving to the canvas #1103

NickOpenFn opened this issue Sep 13, 2023 · 1 comment
Assignees
Labels
ux/ui improvement Improvements to the look, feel and usability of the system

Comments

@NickOpenFn
Copy link

NickOpenFn commented Sep 13, 2023

Loom: https://www.loom.com/share/04d9d51eb1d041b6a4245ce964acb140?sid=47eb8e64-8b79-43c6-a4c4-ce4e340dde2a
Figma: https://www.figma.com/file/2Uvr2jOaQh6rQNR1cHlLKM/App?type=design&node-id=186-556&mode=design


Background:

  • Right now, clicking "Create Workflow" takes you straight to the canvas and creates a randomised name for the workflow.
  • I don't think this is the best practice, and requires extra steps to change the name once in the canvas.
  • In addition, I don't believe the generated names add any value
  • Funny note: After creating this card we got some internal feedback, and this was one of the quirks that came up

Solution:

  • When clicking the "Create Workflow" button in the workflow page, we display a modal window asking for the Workflow name.
  • We don't allow multiple Workflows with the same name
  • When creating the workflow, it is created and saved (right now, when you create a workflow you have to hit the "Save" button once inside the canvas)

Implementation notes

  • Create button is disabled until a name is input
  • If the name already exists, show a validation error (we should check this on each keypress)
  • If user hovers on the disabled create button, tooltip displays
  • Cancel or pressing the "X" closes the modal
  • Modal should use our existing components and not deviate from them at all (regardless of my design).

Note: Chat to @midigofrank regarding modals

@NickOpenFn NickOpenFn added ux/ui improvement Improvements to the look, feel and usability of the system discussion Discussion needed to hash out more details prior to development labels Sep 13, 2023
@NickOpenFn NickOpenFn removed the discussion Discussion needed to hash out more details prior to development label Sep 20, 2023
@NickOpenFn
Copy link
Author

@benedictus-dev Sorry, realise you weren't in the loop here! We will deploy this after everything has been merged into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux/ui improvement Improvements to the look, feel and usability of the system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants