Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google credential creation not working #1109

Closed
NickOpenFn opened this issue Sep 13, 2023 · 3 comments · Fixed by #1482
Closed

Google credential creation not working #1109

NickOpenFn opened this issue Sep 13, 2023 · 3 comments · Fixed by #1482
Assignees
Labels
bug Newly identified bug

Comments

@NickOpenFn
Copy link

NickOpenFn commented Sep 13, 2023

Note that this should be done alongside #688

Creation of the Google credential via oAuth leads you to a page "you can close this" and doesn't create the credential within OpenFn.

  1. oAuth should open up in a new window, not tab.
  2. oAuth window should automatically close on success (refresh OpenFn if necessary).
  3. We should display a toast that the credential has been created.

Noting: This whole workflow for Credential creation needs to be rethought in terms of better UX

@stuartc
Copy link
Member

stuartc commented Nov 23, 2023

We should check if we can move some of the credential creation into the callback controller.

@NickOpenFn
Copy link
Author

@NickOpenFn
Copy link
Author

@benedictus-dev
Great on getting the oAuth working!
Based on the conversation, let's extend this to:

  1. FIX: Fix the "Re-auth" process that has that refresh token issue
  2. QUESTION: There is a scenario that the user can remove OpenFn from their apps on Google account. If that is the case and a linked credential has a job that is run, what is returned.

Noting here for myself:

  • We should have the ability to remove the oAuth connection from OpenFn's side and the ability to re-auth. This is the case when someone accidentally links their incorrect account (I'm guilty of this far too often). I also think there may be a requirement on Google's oAuth usage that states that you may need to offer this to the users.
  • IIRC there is a way to pragmatically know if the connection breaks (which we had at Groove). Going to ask the team there how we did that in the past.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Newly identified bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants