Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash and wrong error message when setting up version control #1112

Closed
taylordowns2000 opened this issue Sep 14, 2023 · 2 comments · Fixed by #1147
Closed

Crash and wrong error message when setting up version control #1112

taylordowns2000 opened this issue Sep 14, 2023 · 2 comments · Fixed by #1147
Assignees
Labels
bug Newly identified bug

Comments

@taylordowns2000
Copy link
Member

taylordowns2000 commented Sep 14, 2023

https://www.loom.com/share/7add73420ff448ebb4a7d65af3869d66?sid=199cf13e-be48-4f88-b647-0c457e14ea21

  1. When trying to set up Github version control from an "admin" project_user the Github page doesn't redirect them back to the right page.
  2. When going back to the workflow page, no repo or branch is available.
  3. The app displays a "bad github cert" message, but the cert is not bad because we know it works properly for the superuser.
  4. No error message is sent to Sentry.
  5. No error is visible in the logs.
  6. It appears that a project_repo_connection has been built

Github version control works perfectly for the superuser on app.openfn.org

here is the link the loading stops on: http://app.openfn.org/setup_vcs?installation_id=41428355&setup_action=update

@taylordowns2000 taylordowns2000 added the bug Newly identified bug label Sep 14, 2023
@NickOpenFn
Copy link

Hey team! Please add your planning poker estimate with Zenhub @midigofrank @taylordowns2000

@taylordowns2000
Copy link
Member Author

Things to consider:

  1. first try to get some errors to appear.
  2. seems to work where user.role == superuser and project_user.role == owner
  3. seems to fail all other times... consider that user.role should never come into play here. you can create a github connection or click "sync" if your project_user.role is either admin or owner.
  4. If it's not admin or owner you should see a message saying that you can't manage github for this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Newly identified bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants