Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Job name creator breaking when open & selecting an existing job #1220

Closed
2 tasks done
NickOpenFn opened this issue Oct 18, 2023 · 2 comments · Fixed by #1569
Closed
2 tasks done

Job name creator breaking when open & selecting an existing job #1220

NickOpenFn opened this issue Oct 18, 2023 · 2 comments · Fixed by #1569
Assignees
@elias-ba
Labels
bug Newly identified bug

Comments

@NickOpenFn
Copy link

NickOpenFn commented Oct 18, 2023 •
edited by elias-ba

https://www.loom.com/share/4ff4e4f5e65b4151a48ffe4ee6947e54?sid=ed0da86f-956a-48ed-a9ad-e5e790a51116

  • Close the name creator input when selecting a existing job
  • See if there is a underlying bug that is a concern on the job panel not working on closing the input field

Do this with #1218
@NickOpenFn NickOpenFn changed the title Job name creator breaking when selecting an existing job Job name creator breaking when open & selecting an existing job Nov 9, 2023
@NickOpenFn NickOpenFn added the bug Newly identified bug label Nov 9, 2023
@taylordowns2000 taylordowns2000 mentioned this issue Nov 9, 2023
Closed
@mtuchi mtuchi self-assigned this Nov 16, 2023
@mtuchi mtuchi linked a pull request Nov 27, 2023 that will close this issue
wip: close job placeholder #1466
Closed
4 tasks
@mtuchi mtuchi mentioned this issue Nov 27, 2023
Closed
4 tasks
@NickOpenFn
Copy link
Author

Keeping this in blocked till Mtuchi has capacity to jump on and wrap it up

@NickOpenFn
Copy link
Author

Mtuchi is too busy at the moment - pushing this back to the hitlist.

@elias-ba elias-ba self-assigned this Dec 7, 2023
@elias-ba elias-ba mentioned this issue Dec 12, 2023
Closed
4 tasks
stuartc added a commit that referenced this issue Dec 14, 2023
@stuartc
Refactor the WorkflowDiagram selection logic
516a88e 
- The currently selected id is now derived only from the URL.
- The switching appears immediately because we pull the selection off the URL from the `navigate` event (i.e. before the liveview has to reply).
- This change appears to reduce render calls and fixes what looks like the node being selected twice.
- I've changed the logic for cancelling a placeholder, if you hit Esc, it cancels it.

Fixes #1220
@stuartc stuartc mentioned this issue Dec 14, 2023
Merged
4 tasks
stuartc added a commit that referenced this issue Dec 14, 2023
@stuartc
Refactor the WorkflowDiagram selection logic
9bf2bf9 
- The currently selected id is now derived only from the URL.
- The switching appears immediately because we pull the selection off the URL from the `navigate` event (i.e. before the liveview has to reply).
- This change appears to reduce render calls and fixes what looks like the node being selected twice.
- I've changed the logic for cancelling a placeholder, if you hit Esc, it cancels it.

Fixes #1220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elias-ba elias-ba

Labels
bug Newly identified bug
Projects
None yet
Milestone
No milestone
3 participants
@mtuchi @elias-ba @NickOpenFn