Drop invocation reasons #1412
Merged
Drop invocation reasons #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1412 +/- ##
==========================================
+ Coverage 86.15% 86.83% +0.67%
==========================================
Files 218 216 -2
Lines 6457 6357 -100
==========================================
- Hits 5563 5520 -43
+ Misses 894 837 -57 ☔ View full report in Codecov by Sentry. |
jyeshe
reviewed
Nov 21, 2023
priv/repo/migrations/20231120112129_remove_invocation_reasons_and_constraints.exs
Outdated
Show resolved
Hide resolved
benedictus-dev
requested review from
taylordowns2000
and removed request for
midigofrank
taylordowns2000
requested changes
Nov 21, 2023
There was a problem hiding this comment.
hey @benedictus-dev , looking great. quick things:
- please update the changelog
- I still see both
InvocationReasonandInvocationReasonsin here. Should those files be deleted? If not, why not? - In one of your changes to the
attempt_service_test, I noticed this line. Should we drop this test (and the corresponding function from the attempt service?)
This isn't an exhaustive review, but would love for you to address these things before asking for a review from Stu.
Touch up tests and remove (with their tests): - Lightning.AttemptService - Lightning.Workflows.Graph (replaced by Lightning.Graph) Closes: #1412
stuartc
force-pushed
the
1402-drop-invocation-reasons-from-DB
branch
from
24eb157
to
bf6b246
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for the reviewer
Related issue
Invocation reasons are no longer be generated. This PR drops the table from the DB and remove all unused code in the InvocationReason module.
Fixes #1402
Review checklist