Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ellipses on credential info on job editor heading #1428

Closed
NickOpenFn opened this issue Nov 21, 2023 · 4 comments · Fixed by #1462
Closed

Add ellipses on credential info on job editor heading #1428

NickOpenFn opened this issue Nov 21, 2023 · 4 comments · Fixed by #1462
Assignees
@benedictus-dev

Comments

@NickOpenFn
Copy link

NickOpenFn commented Nov 21, 2023 •
edited

Display ellipses on the headers so they don't span over two lines.
We should show the full contents on hover with tooltips (browser)

Private Zenhub Image
@NickOpenFn NickOpenFn changed the title Add elippsis on credential info on job editor heading Add ellipses on credential info on job editor heading Nov 21, 2023
@NickOpenFn
Copy link
Author

Hey team! Please add your planning poker estimate with Zenhub @elias-ba @jyeshe @midigofrank @stuartc

@NickOpenFn
Copy link
Author

Whoever does this to pass on code review to Roger

@stuartc
Copy link
Member

stuartc commented Nov 23, 2023 

whitespace-nowrap text-ellipsis

And add a title=.... to the element.

@benedictus-dev benedictus-dev mentioned this issue Nov 25, 2023
Merged
4 tasks
@NickOpenFn
Copy link
Author

@taylordowns2000 Why was this moved back to UX review?

taylordowns2000 added a commit that referenced this issue Nov 30, 2023
@taylordowns2000
fix tailwind for #1428
58ee9a2
taylordowns2000 added a commit that referenced this issue Nov 30, 2023
@taylordowns2000
fix tailwind for #1428
1b464fc
taylordowns2000 added a commit that referenced this issue Nov 30, 2023
@benedictus-dev @benedictus-yevu @taylordowns2000
Add ellipses on credential and adaptor info in inspector heading (#1462)
92cb9b5 
* Add ellipses on credential info on job editor heading

* update changelog

* code cleanup

* fix tailwind for #1428

---------

Co-authored-by: benedictus-yevu <benedictusyevu@yahoo.com>
Co-authored-by: Taylor Downs <downs.taylor@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benedictus-dev benedictus-dev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ellipses on credential info on job editor heading OpenFn/lightning
3 participants
@stuartc @benedictus-dev @NickOpenFn