Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UI when non-accessible users access project security settings #1477

Closed
NickOpenFn opened this issue Nov 28, 2023 · 4 comments · Fixed by #1566 or #1604
Closed

Improve UI when non-accessible users access project security settings #1477

NickOpenFn opened this issue Nov 28, 2023 · 4 comments · Fixed by #1566 or #1604
Assignees
@midigofrank
Labels
bug Newly identified bug

Comments

@NickOpenFn
Copy link

NickOpenFn commented Nov 28, 2023 •
edited

Currently users that don't have access to the MFA page attached (assuming by role, this screenshot was created by an Editor)

Possible solutions:

  • Hide menu item for MFA on navigation and 404 if user tries to access it

Private Zenhub Image
@NickOpenFn NickOpenFn added bug Newly identified bug unplanned Items included in a existing sprint that weren't part of the initial Sprint backlog labels Nov 30, 2023
@NickOpenFn
Copy link
Author

Hey team! Please add your planning poker estimate with Zenhub @benedictus-dev @elias-ba @jyeshe @midigofrank @stuartc

@NickOpenFn NickOpenFn removed the unplanned Items included in a existing sprint that weren't part of the initial Sprint backlog label Dec 8, 2023
@jyeshe jyeshe assigned jyeshe and unassigned jyeshe Dec 12, 2023
@midigofrank midigofrank changed the title Improve UI when non-accessible users access MFA page Improve UI when non-accessible users access project settings Dec 13, 2023
@midigofrank midigofrank changed the title Improve UI when non-accessible users access project settings Improve UI when non-accessible users access project security settings Dec 13, 2023
@midigofrank midigofrank mentioned this issue Dec 13, 2023
Merged
4 tasks
@taylordowns2000
Copy link
Member

noting that we will make this page visible and make the button appropriately read-only for viewer or editor users soon @NickOpenFn

@taylordowns2000
Copy link
Member

hey @midigofrank , i'm re-opening this because i had to revert one of your changes here: https://github.com/OpenFn/Lightning/pull/1591/files#diff-ab2038829f13be727c2f8f9dbb8507b687a5931dd1560c6739c60b02e5f0d834

please confirm that you've got everything you need to close #1477 despite me reverting this bit of code.

@midigofrank
Copy link
Collaborator

Hey @taylordowns2000 , I think I do. I'll first look into why this caused the issue #1589 in the attempt viewer.

@midigofrank midigofrank mentioned this issue Jan 9, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@midigofrank midigofrank

Labels
bug Newly identified bug
Projects
None yet
Milestone
No milestone
4 participants
@taylordowns2000 @midigofrank @jyeshe @NickOpenFn