Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different table type shown on Webhook security page in settings #1514

Closed
NickOpenFn opened this issue Dec 1, 2023 · 0 comments · Fixed by #1736
Closed

Different table type shown on Webhook security page in settings #1514

NickOpenFn opened this issue Dec 1, 2023 · 0 comments · Fixed by #1736
Labels
ux/ui improvement Improvements to the look, feel and usability of the system

Comments

@NickOpenFn
Copy link

NickOpenFn commented Dec 1, 2023

Via Taylor: https://www.loom.com/share/d6e3edb3285c4fde8e5ba575e68df63a

We need to refactor the Webhook security table that is used in the settings ( 'https://demo.openfn.org/projects/xxx/settings#webhook_security' ) to be consistent with the tables on other pages. This is exceptionally important for when we introduced a more cohesive styleguide so that the improvements and changes are consistent across the board.

Noting: Just looking at the inspector, it really does seem that a different table was created here. If that was to better handle the hover events, we should discuss a better long term strategy so we don't have components in isolation

@NickOpenFn NickOpenFn added the ux/ui improvement Improvements to the look, feel and usability of the system label Dec 1, 2023
@taylordowns2000 taylordowns2000 mentioned this issue Feb 10, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux/ui improvement Improvements to the look, feel and usability of the system
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant