Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strings get sent to the worker where booleans should #1518

Closed
taylordowns2000 opened this issue Dec 3, 2023 · 0 comments · Fixed by #1530
Closed

Strings get sent to the worker where booleans should #1518

taylordowns2000 opened this issue Dec 3, 2023 · 0 comments · Fixed by #1530
Assignees
Labels
bug Newly identified bug unplanned Items included in a existing sprint that weren't part of the initial Sprint backlog

Comments

@taylordowns2000
Copy link
Member

Building on #1513, I'm seeing that all values (including booleans) are being saved to the DB as strings. When they get passed to the worker, they no longer match the required JSON schema specification and we're probably going to run into a bunch of issues with this down the line.

Put simply, we're sending

{"requireSsl": "true"}

to the worker while the schema requires that we send

{"requireSsl": true}

Please check all types that we handle in the config schema and ensure that they're sent to the worker properly.

@taylordowns2000 taylordowns2000 added bug Newly identified bug unplanned Items included in a existing sprint that weren't part of the initial Sprint backlog labels Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Newly identified bug unplanned Items included in a existing sprint that weren't part of the initial Sprint backlog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants