Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming in codebase to match new name "step" on UI #1571

Closed
NickOpenFn opened this issue Dec 14, 2023 · 4 comments
Closed

Renaming in codebase to match new name "step" on UI #1571

NickOpenFn opened this issue Dec 14, 2023 · 4 comments
Assignees

Comments

@NickOpenFn
Copy link

NickOpenFn commented Dec 14, 2023

Rename Runs to Steps
Rename AttemptRuns to AttemptSteps

Do not rename Attempts to Runs as this is non-blocking and can only happen after this issue is closed. We'll track that second issue elsewhere, and it's lower priority than this one.

Next issue: #1657

@OpenFn OpenFn deleted a comment from NickOpenFn Jan 10, 2024
@taylordowns2000
Copy link
Member

needs some discussion:

running stuff

v0.10: work order > attempt > attempt_run <> run
v2:    work order > run     > run_step    <> step

building stuff

v0.10: project > workflow > job
v2: project > workflow > job (but we also refer to it as a 'step' in the UI)

note that “step” as used in the UI is super contextual: if you’re looking at a workflow, step means the little boxes/jobs.
if you’re looking at a run, step means the instances of execution of those little boxes/jobs during this run.

@taylordowns2000
Copy link
Member

given how expensive engineering work will get while this isn't finished, i'd vote we put this at the top of the backlog as soon as @stuartc is back and we're 100% aligned on the names. as expected, we've already had a number of costly back-and-forth conversations and bugs related this one.

sheet with naming proposal: https://docs.google.com/spreadsheets/d/1CtFq5fwZ_UtZ7r7Kam96Ja_3ixVNpT0dal3_EClPyiM/edit#gid=0

@taylordowns2000
Copy link
Member

Hey team! Please add your planning poker estimate with Zenhub @elias-ba @jyeshe @midigofrank @stuartc

@stuartc
Copy link
Member

stuartc commented Jan 18, 2024

My advice here is to start with Run -> Step, break it via renaming/changing the module name.

Change the relationship names (while perhaps overriding the foreign keys value), and delaying the migrations as much as possible.

@taylordowns2000 taylordowns2000 changed the title Internal renaming in codebase to match new naming on UI Renaming in codebase to match new name "step" on UI Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants