Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: navigating to attempt no longer displays logs or highlights lines associated with runs #1589

Closed
2 tasks
taylordowns2000 opened this issue Dec 23, 2023 · 2 comments · Fixed by #1591
Closed
2 tasks
Assignees
Labels
bug Newly identified bug

Comments

@taylordowns2000
Copy link
Member

taylordowns2000 commented Dec 23, 2023

Until recently, clicking into an attempt (or an individual run) would take the user to the attempt viewer with the logs displayed. If a run was selected, the log lines from that run would be highlighted with a yellow bar. This still works on v0.12.0.

Now, the attempt viewer is loaded but no logs are displayed until the user clicks on "logs" and the highlighting is gone.

What it should look like: v0.12.0 has highlighting and logs displayed by default:
image

What it looks like now: adad9a8 does not:
image

ToDo:

  • Make it so that logs are displayed by default again when you view an attempt
  • Make it so that the yellow highlighting bar indicates which log lines belong to a specific run if a run within the attempt is selected
@taylordowns2000 taylordowns2000 added the bug Newly identified bug label Dec 23, 2023
@taylordowns2000 taylordowns2000 changed the title Navigating to attempt no longer displays logs Regression: Navigating to attempt no longer displays logs or highlights lines Dec 23, 2023
@taylordowns2000 taylordowns2000 changed the title Regression: Navigating to attempt no longer displays logs or highlights lines Regression: navigating to attempt no longer displays logs or highlights lines associated with runs Dec 23, 2023
@taylordowns2000
Copy link
Member Author

@elias-ba , @jyeshe , i took a peek at the changes made to run_live over the last few days and I can't quite work out what caused this regression. i think that both of you have had some interaction with this part of the app recently, would you please see if you can restore the functionality described above?

@taylordowns2000
Copy link
Member Author

Update here: the bug comes from this commit by @midigofrank .

I bet it's assets/js/hooks/TabSelector.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Newly identified bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant