Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salesforce Oauth credential #1633

Closed
2 of 3 tasks
taylordowns2000 opened this issue Jan 17, 2024 · 2 comments · Fixed by #1678
Closed
2 of 3 tasks

Salesforce Oauth credential #1633

taylordowns2000 opened this issue Jan 17, 2024 · 2 comments · Fixed by #1678
Assignees

Comments

@taylordowns2000
Copy link
Member

taylordowns2000 commented Jan 17, 2024

User story

As a user connecting to Salesforce, I'd like to be able to use an Oauth2 connection rather than my username/password/securityToken.

Details

  1. This is a new "Salesforce Oauth" credential type.
image
  1. The "sign in with google" here should be replaced by Sign in with Salesforce button:
image image

Implementation notes

We will probably need to create a Salesforce connected app for the global OpenFn instance (app.openfn.org) and another for testing locally (localhost:4000) - https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/intro_oauth_and_connected_apps.htm

From @aleksa-krolls : Customers will need different scopes depending on their requirements and there could be use cases for using all sorts of combos of these. I think usually we’d need refresh_token, id, api… and maybe full or lightning (not our lighting) but we should build the adaptor in a way we can change these. See this docs article for more on scopes: https://help.salesforce.com/s/articleView?id=sf.remoteaccess_oauth_tokens_scopes.htm&language=en_US&type=5

  1. Check Google Oauth form
  2. Consider how we know which scopes to show to the user

Release notes

  • Added Oauth2 option for Salesforce connections

User acceptance criteria

  • I can create a new Salesforce credential
  • When I create a new Salesforce credential, I can select which scopes to request.
  • I can successfully create records in a Salesforce system using the Salesforce adaptor (version: ______ @mtuchi )
@taylordowns2000
Copy link
Member Author

Hey team! Please add your planning poker estimate with Zenhub @midigofrank @stuartc @elias-ba @jyeshe

@taylordowns2000
Copy link
Member Author

  • nothing that the final bit here is handling the lack of an expires_at value on the initial credential save.
  • if we don't get an expires at, we should probably handle this when we are checking expiry not on save.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants