Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Attempts" to "Runs" in the backend #1657

Closed
taylordowns2000 opened this issue Jan 22, 2024 · 4 comments · Fixed by #1682
Closed

Rename "Attempts" to "Runs" in the backend #1657

taylordowns2000 opened this issue Jan 22, 2024 · 4 comments · Fixed by #1682
Assignees

Comments

@taylordowns2000
Copy link
Member

After #1571 is delivered, the words run and attempt are both used to describe Thing X in this hierarchy:

Workflow
 ↳ Work Order
  ↳ Thing X (`attempts` table, "Run" in the UI, `Attempt` or `Run` in most parts of the backend)
   ↳ Step   

Rename all places where attempt is used to call it a run.

@taylordowns2000
Copy link
Member Author

all good here, but blocked until we release @openfn/ws-worker@0.8.0 - want to talk with joe about that tomorrow to sort out some options naming stuff, but I expect to have both ready by tomorrow EOD

@stuartc
Copy link
Member

stuartc commented Jan 30, 2024

@taylordowns2000 why do we need to wait? I thought the worker channel was backwards compatible?

@taylordowns2000
Copy link
Member Author

the run stuff was backwards compatible, but this new stuff has some annoying contractual bits... built compatibility for several, but the one that got me was that the old worker expects an object with an attempts key in it and I don't want to send both attempts and runs during the transition

@stuartc
Copy link
Member

stuartc commented Jan 30, 2024

Could we add versioning, that way this (and any other changes) won't expose us to version incompatibilities that require all pods to be shut down before deploy..

i.e. opt in changes, like only if the version is provided (and/or is greater than x) then we treat it differently...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants