Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display dataclips the same as jobs receive state #1664

Closed
stuartc opened this issue Jan 23, 2024 · 0 comments · Fixed by #1665
Closed

Display dataclips the same as jobs receive state #1664

stuartc opened this issue Jan 23, 2024 · 0 comments · Fixed by #1665
Assignees
@taylordowns2000
Labels
unplanned Items included in a existing sprint that weren't part of the initial Sprint backlog ux/ui improvement Improvements to the look, feel and usability of the system

Comments

@stuartc
Copy link
Member

stuartc commented Jan 23, 2024

Currently when viewing a dataclip, you see the body field as-is.

However when a job is executed, the state it receives may be different. For example http_request types internally are stored as the json body from the request they are sent to the worker as: {"data": <body>, "request": <request>}.

We should show them as they appear in to the worker.

Places that show dataclips

  • Manual Run input panel
  • Run viewer input tab
  • Dataclip view page

Notes

There is a function in Attempts called get_input/1, this can be used as a reference for a reusable implementation for Dataclips in general.
taylordowns2000 added a commit that referenced this issue Jan 23, 2024
@taylordowns2000
fix #1664
f5492ea
@taylordowns2000 taylordowns2000 mentioned this issue Jan 23, 2024
Merged
4 tasks
@taylordowns2000 taylordowns2000 added unplanned Items included in a existing sprint that weren't part of the initial Sprint backlog ux/ui improvement Improvements to the look, feel and usability of the system labels Jan 24, 2024
@taylordowns2000 taylordowns2000 self-assigned this Jan 24, 2024
taylordowns2000 added a commit that referenced this issue Jan 24, 2024
@taylordowns2000
fix #1664
ec95f51
taylordowns2000 added a commit that referenced this issue Jan 26, 2024
@taylordowns2000
fix #1664 (#1665)
6ae77b0 
* fix #1664

* fix failing test

* update changelog
taylordowns2000 added a commit that referenced this issue Jan 26, 2024
@taylordowns2000
finish #1664
5fbae70
taylordowns2000 added a commit that referenced this issue Jan 26, 2024
@taylordowns2000
finish #1664 by removing state assembler language (#1676)
9fd626d 
* finish #1664

* prefer unless
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taylordowns2000 taylordowns2000

Labels
unplanned Items included in a existing sprint that weren't part of the initial Sprint backlog ux/ui improvement Improvements to the look, feel and usability of the system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

display http_request dataclips in their initial state format #1664 OpenFn/lightning
2 participants
@stuartc @taylordowns2000