Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jobs panel is super SLOW for first open after restart #567

Closed
taylordowns2000 opened this issue Jan 9, 2023 · 4 comments · Fixed by #640
Closed

Jobs panel is super SLOW for first open after restart #567

taylordowns2000 opened this issue Jan 9, 2023 · 4 comments · Fixed by #640
Labels
bug Newly identified bug
Milestone

Comments

@taylordowns2000
Copy link
Member

To reproduce, restart your server and not the difference in time it takes to open the jobs panel the first time, then all subsequent times.

Implementation Notes:

  • This is because we lazy load the list of adaptors from the file system. (@stuartc , is this definitely reading from the filesystem, or from NPM?)
  • It should be handled by spawning a new task that does this async during startup. I.e., don't block startup (because that would add to the delay before the inbox URL comes online) but rather spawn an async task that loads the list of adaptors during startup and the continue on your merry way.
@taylordowns2000 taylordowns2000 added the bug Newly identified bug label Feb 8, 2023
taylordowns2000 added a commit that referenced this issue Feb 13, 2023
@amberrignell
Copy link
Contributor

Potential solution: expose the caching option to give people the choice and document it.
(ex so they can enable it for dev mode)

@taylordowns2000
Copy link
Member Author

taylordowns2000 commented Feb 14, 2023 via email

@stuartc
Copy link
Member

stuartc commented Feb 14, 2023

@taylordowns2000 lets split this to get everyone happy and less annoyed asap - so enable caching by default and document it. Then we address the cache + refresh facility as it's probably a bit more effort than just setting some ENV vars.

@taylordowns2000
Copy link
Member Author

ok. can you @stuartc discuss priority with @amberrignell at standup today?

stuartc added a commit that referenced this issue Feb 14, 2023
debug slow AdaptorRegistry loading, closes #567
@amberrignell amberrignell added this to the Happy Cicada milestone Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Newly identified bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants