Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand scope and tests for "delete_project" function #759

Closed
5 tasks
taylordowns2000 opened this issue Apr 3, 2023 · 1 comment · Fixed by #798
Closed
5 tasks

Expand scope and tests for "delete_project" function #759

taylordowns2000 opened this issue Apr 3, 2023 · 1 comment · Fixed by #798
Assignees
@mtuchi

Comments

@taylordowns2000
Copy link
Member

  • Either via appropriate use of cascades or via well-planned associated deletes, we should ensure that the Projects.delete_project function removes all associated project activity.
  • Note that it does not remove users or credentials, but does remove project_users and project_credentials.

Testing

  • Ensure that an attempted project deletion tries to delete a project with every different type of associated resource, including:

  • workorders, attempts, run

  • audit trail events

  • project users

  • project credentials

  • jobs and triggers
@mtuchi mtuchi self-assigned this Apr 19, 2023
@mtuchi mtuchi linked a pull request Apr 19, 2023 that will close this issue
Expand scope of delete project function #798
Merged
7 tasks
@mtuchi mtuchi mentioned this issue Apr 19, 2023
Merged
7 tasks
@mtuchi mtuchi reopened this May 8, 2023
@amberrignell
Copy link
Contributor

closed by #798 and #847

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtuchi mtuchi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expand scope of delete project function OpenFn/lightning
3 participants
@mtuchi @taylordowns2000 @amberrignell