Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edges and Nodes: Model Refactor #794

Closed
stuartc opened this issue Apr 18, 2023 · 0 comments · Fixed by #797
Closed

Edges and Nodes: Model Refactor #794

stuartc opened this issue Apr 18, 2023 · 0 comments · Fixed by #797
Assignees
Labels
architecture Issue related to the architecture of the lightning

Comments

@stuartc
Copy link
Member

stuartc commented Apr 18, 2023

Details

See: #793

  • Create a new WorkflowEdge model.
  • Create a service to create a Workflow that creates the WorkflowEdges,
    Jobs and Triggers.
  • Hunt down the places (starting with the test fixtures) where we create a
    Workflow, Job and Trigger and replace them with the new service.
  • We may need to relax the database constraints on the Trigger model to allow
    for upstream_job_id to be blank.
  • Triggers no longer require on_success and on_failure types.

Implementation notes

@stuartc stuartc added the architecture Issue related to the architecture of the lightning label Apr 18, 2023
@stuartc stuartc self-assigned this Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Issue related to the architecture of the lightning
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant