Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show that the jobs' body is invalid #957

Closed
stuartc opened this issue Jul 25, 2023 · 2 comments · Fixed by #1036
Closed

Show that the jobs' body is invalid #957

stuartc opened this issue Jul 25, 2023 · 2 comments · Fixed by #1036
Assignees

Comments

@stuartc
Copy link
Member

stuartc commented Jul 25, 2023

Currently we have no UX/UI hints that a Job's body is invalid.
At the moment, the only invalid state that exists is when the body for the code editor is empty.

In future, we will have another story expanding this for other error states.

Technical Notes

Unlike #956 this button exists in LiveView.

Lets not change the Ecto model validation messages: i.e. "body can't be blank".
But rather use the .errors struct and it's metadata to determine if the validation failure for body is from a validate_required etc.

@stuartc stuartc added the needs detail More detail is needed before development can start label Jul 25, 2023
@osinga
Copy link
Collaborator

osinga commented Jul 27, 2023

We're looking for two changes here:

  1. Add an error label next to the "Save" button in the editor modal when the editor is empty
    This is for immediate feedback when you try and save your changes.

Canvas

  1. Add an error label next to the editor button in the job settings modal
    This is for when you've gone out of the editor modal while still in an invalid state. Otherwise you might run into the situation where we indicate the presence of an invalid node (Show that a node is invalid #956) but you can't see what's actually invalid.

Canvas-2

Design

@taylordowns2000 taylordowns2000 removed the needs detail More detail is needed before development can start label Aug 1, 2023
@NickOpenFn
Copy link

Hey team! Please add your planning poker estimate with Zenhub @elias-ba @stuartc @zacck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants