Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve feedback when a Workflow name is invalid #961

Closed
stuartc opened this issue Jul 25, 2023 · 4 comments · Fixed by #1040
Closed

Improve feedback when a Workflow name is invalid #961

stuartc opened this issue Jul 25, 2023 · 4 comments · Fixed by #1040
Assignees

Comments

@stuartc
Copy link
Member

stuartc commented Jul 25, 2023

It's not obvious that the Workflow name is a required field.

This requires some UX/UI input and design to get this right.

@stuartc stuartc added the needs detail More detail is needed before development can start label Jul 25, 2023
@osinga
Copy link
Collaborator

osinga commented Jul 27, 2023

Workflow Name Input

  • Display the workflow name as regular text (not an input)
  • Add a button with icon Pencil beside the name
    • Clicking the button replaces the workflow name with an input
    • Hitting enter while in the input submits it and returns to the initial state
      • If invalid, show the invalid state (with the error on the side for the sake of space)

Workflow Name

@taylordowns2000 taylordowns2000 removed the needs detail More detail is needed before development can start label Aug 1, 2023
@NickOpenFn
Copy link

Hey team! Please add your planning poker estimate with Zenhub @elias-ba @stuartc @zacck

@elias-ba elias-ba self-assigned this Aug 15, 2023
@NickOpenFn NickOpenFn self-assigned this Aug 17, 2023
@NickOpenFn
Copy link

NickOpenFn commented Aug 17, 2023

UI to be improved slightly, and passed along to Elias with Figma:

  • pencil icon to have opacity .
  • transitions to 0 when text has hover
  • Show input field on select (or underline, depending on what's easiest)
  • label for save fail/succeeded to be improved slightly (padding, position)

@elias-ba
Copy link
Contributor

  1. Make workflow name input look exactly same as job name input
  2. Make workflow name input occupy all the space to the save button
  3. When there's an error put the error in the right side of the workflow name input and make it look same as design
  4. Make pencil gray

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants