Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement skipped CredentialLive tests #962

Closed
stuartc opened this issue Jul 25, 2023 · 1 comment · Fixed by #1061
Closed

Reimplement skipped CredentialLive tests #962

stuartc opened this issue Jul 25, 2023 · 1 comment · Fixed by #1061
Assignees
@elias-ba

Comments

@stuartc
Copy link
Member

stuartc commented Jul 25, 2023 •
edited

These are existing tests that are skipped:

  • create new credential from job inspector and update the job form
  • open credential modal from the job inspector (edit_job)
  • create new credential from job inspector and update the job form

and rewritten to use the new elements/behaviour.

These three tests should be moved to the WorkflowLive.Edit tests, and arguably written as one test.
@NickOpenFn
Copy link

Hey team! Please add your planning poker estimate with Zenhub @elias-ba @stuartc @zacck

@zacck zacck removed their assignment Aug 25, 2023
@elias-ba elias-ba self-assigned this Aug 29, 2023
@elias-ba elias-ba mentioned this issue Aug 29, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elias-ba elias-ba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move & Reimplement Skipped CredentialLive Tests OpenFn/lightning
4 participants
@stuartc @elias-ba @zacck @NickOpenFn