Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a new job is created, the default edge will never be run #977

Closed
taylordowns2000 opened this issue Jul 26, 2023 · 0 comments · Fixed by #978
Closed

When a new job is created, the default edge will never be run #977

taylordowns2000 opened this issue Jul 26, 2023 · 0 comments · Fixed by #978
Labels
bug Newly identified bug

Comments

@taylordowns2000
Copy link
Member

Note how the edges between a newly created job (bottom-most) or between a downstream job and its parent when the edge hasn't been specifically modified and saved (right-side) is an ∞ symbol. This is invalid and will not let the downstream job run

image.png

Until we support the new edge conditions, this needs to go back to being an on_success edge.
@taylordowns2000 taylordowns2000 added the bug Newly identified bug label Jul 26, 2023
taylordowns2000 added a commit that referenced this issue Jul 26, 2023
@taylordowns2000
require edge condition, set default to on_success, fix #977
07f4538
@taylordowns2000 taylordowns2000 mentioned this issue Jul 26, 2023
Merged
4 tasks
taylordowns2000 added a commit that referenced this issue Jul 26, 2023
@taylordowns2000
changelog for fix #977
100220a
stuartc pushed a commit that referenced this issue Jul 27, 2023
@taylordowns2000
require edge condition, set default to on_success, fix #977 (#978)
0a9eeb2 
* require edge condition, set default to on_success, fix #977

* handle always in trigger-to-job edges

* edges need conditions

* changelog for fix #977

* remove leftover inspect()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Newly identified bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

require edge condition, set default to on_success, fix #977 OpenFn/lightning
1 participant
@taylordowns2000