Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the internal network port with "web" for the worker #1485

Merged
merged 1 commit into from Dec 6, 2023

Conversation

delcroip
Copy link
Contributor

@delcroip delcroip commented Nov 29, 2023

use the internal network port with "web" for the worker

was setup to external blocking the change of external

here the result:

lightning-dev-worker-1  | 
lightning-dev-worker-1  | > @openfn/ws-worker@0.2.11 start:prod /app/packages/ws-worker
lightning-dev-worker-1  | > node dist/start.js "-l" "ws://web:4004/worker"
lightning-dev-worker-1  | 
lightning-dev-worker-1  | [RTE] ⚠ Using default repo directory:  /tmp/openfn/worker/repo
lightning-dev-worker-1  | [RTE] ℹ repoDir set to  /tmp/openfn/worker/repo
lightning-dev-worker-1  | [RTE] ℹ memory limit set to 500mb
lightning-dev-worker-1  | [RTE] ❯ Loading workers from  /app/packages/engine-multi/dist/worker/worker.js
lightning-dev-worker-1  | [SRV] ✔ ws-worker vast-moose-knock listening on 2222
lightning-dev-worker-1  | [SRV] ✔ Connected to Lightning at ws://web:4004/worker
lightning-dev-worker-1  | [SRV] ℹ Starting workloop

@stuartc
Copy link
Member

stuartc commented Dec 6, 2023

@delcroip thanks! 👋

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (89c60ee) 87.50% compared to head (514029d) 87.50%.
Report is 36 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1485   +/-   ##
=======================================
  Coverage   87.50%   87.50%           
=======================================
  Files         214      214           
  Lines        6346     6346           
=======================================
  Hits         5553     5553           
  Misses        793      793           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stuartc stuartc merged commit 1381c4a into OpenFn:main Dec 6, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants