Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Messages for attempt:log don't appear to be sending to Lightning #434

Closed
taylordowns2000 opened this issue Nov 5, 2023 · 1 comment · Fixed by #435
Closed

Messages for attempt:log don't appear to be sending to Lightning #434

taylordowns2000 opened this issue Nov 5, 2023 · 1 comment · Fixed by #435
Assignees
@josephjclark @taylordowns2000
Labels
bug Something isn't working

Comments

@taylordowns2000
Copy link
Member

@josephjclark , probably another quick one for Monday AM in a pairing session, but I can't see any

[info] [SRV] ℹ 8c40cf3c-7053-40a4-ac11-6e8d5e04421f :: attempt:log :: OK

logs!

Looks like Lightning is listening for these, and they're all defined in ws-worker, but not getting sent.
@taylordowns2000 taylordowns2000 added the bug Something isn't working label Nov 5, 2023
@taylordowns2000 taylordowns2000 mentioned this issue Nov 5, 2023
Closed
@stuartc
Copy link
Member

stuartc commented Nov 6, 2023

@josephjclark @taylordowns2000 I can confirm on my side that the attempt:log handler isn't being called on the attempt channel.

@josephjclark josephjclark mentioned this issue Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josephjclark josephjclark

@taylordowns2000 taylordowns2000

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Worker: Fix attempts log OpenFn/kit
3 participants
@stuartc @josephjclark @taylordowns2000