Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying component B to A in ligand mapping #155

Closed
ijpulidos opened this issue Mar 20, 2023 · 3 comments · Fixed by #157
Closed

Specifying component B to A in ligand mapping #155

ijpulidos opened this issue Mar 20, 2023 · 3 comments · Fixed by #157

Comments

@ijpulidos
Copy link

ijpulidos commented Mar 20, 2023

Currently the LigandAtomMapping class has a componentA_to_componentB parameter that we can use to define the mapping. Some packages or tools might expect a different "directionality" in the mapping, for example in perses is inverted compared to the convention chosen by gufe (hopefully for convenience, but maybe it was just arbitrary on the perses side).

Do we want to have a componentB_to_componentA option for the constructor of a LigandAtomMapping object? That said, I'd think that we want at least to have it unambiguously defined in the docstring, even for the current parameter.

@richardjgowers
Copy link
Contributor

@ijpulidos
Copy link
Author

ijpulidos commented Mar 20, 2023

Oh, that helps, but I meant this https://github.com/OpenFreeEnergy/gufe/blob/main/gufe/mapping/ligandatommapping.py#L25 , that is, when creating the object.

@dotsdl
Copy link
Collaborator

dotsdl commented Mar 21, 2023

Conclusion: a clarifying docstring specifying what the keys, values are in the componentA_to_componentB and componentB_to_componentA property dicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants