Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make get_openmm_platform set threads to 1 if using NoCutoff #704

Open
IAlibay opened this issue Feb 6, 2024 · 0 comments · May be fixed by #752
Open

Make get_openmm_platform set threads to 1 if using NoCutoff #704

IAlibay opened this issue Feb 6, 2024 · 0 comments · May be fixed by #752

Comments

@IAlibay
Copy link
Contributor

IAlibay commented Feb 6, 2024

We should change our handling of https://github.com/OpenFreeEnergy/openfe/blob/main/openfe/protocols/openmm_rfe/_rfe_utils/compute.py#L11 to optionally take in a hint for the type of simulation being used and have it set threads to 1 when you're doing a nocutoff / gas phase simulation.

We could do this at the protocol level, but looking at things it seems like it'll cause a lot of code repetition.

@IAlibay IAlibay linked a pull request Mar 4, 2024 that will close this issue
2 tasks
@IAlibay IAlibay linked a pull request Mar 4, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant