Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client synchronization improvements #283

Merged
merged 6 commits into from
Jun 27, 2024

Conversation

yungcomputerchair
Copy link
Member

@yungcomputerchair yungcomputerchair commented Jun 24, 2024

Makes a few changes to packet ordering during player loading to increase reliability in the client.

  • Moves a few things from PC_ENTER handler to LOADING_COMPLETE handler, fired only once. This way we don't risk packets getting missed.
    • MOTD
    • Auto-fail missions
    • Buddy list sync (fixes bug where buddy list sometimes doesn't populate on login)
  • For Academy only, fix a packet ordering issue causing players with high latency to not see their equipped nanos in the nanocom (fixes Nano icons will occasionally not appear on the Academy build #262)

Copy link
Member

@dongresource dongresource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CakeLancelot
Copy link
Member

I will merge this after testing on the public server for a day or two

We actually don't need to wait for post-load to do the second nano book send.
That adds unnecessary delay. Moving it to right after `P_FE2CL_REP_PC_ENTER_SUCC`
does the trick and gives the client plenty of time to fetch the icons before
loading in-game.
@CakeLancelot CakeLancelot merged commit 17362b2 into OpenFusionProject:master Jun 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nano icons will occasionally not appear on the Academy build
3 participants