Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shader-loader for shader sources #864

Closed
zachmullen opened this issue Jul 12, 2018 · 3 comments · Fixed by #982
Closed

Use shader-loader for shader sources #864

zachmullen opened this issue Jul 12, 2018 · 3 comments · Fixed by #982

Comments

@zachmullen
Copy link
Contributor

Right now they're inlined as arrays of strings with join('\n') called on them.

@manthey
Copy link
Contributor

manthey commented Jul 12, 2018

Many of the shaders are dynamically produced based on features, so are not constant strings. I don't see how shader-loader would work.

@zachmullen
Copy link
Contributor Author

zachmullen commented Jul 12, 2018

Well, there are at least some[1][2][3] that are totally static. For those cases, it would not only improve readability but also remove some unnecessary work that is being done at runtime currently.

I see some examples of dynamic shader code, such as this debug flag. Is that something that could be accomplished with preprocessor directives such that the shader program itself becomes static?

@manthey
Copy link
Contributor

manthey commented Mar 12, 2019

Resolved by #982.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants