Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERROR MESSAGE WHILE SAVING (making it impossible to save) #623

Closed
alexislitvine opened this issue Oct 24, 2023 · 3 comments
Closed

ERROR MESSAGE WHILE SAVING (making it impossible to save) #623

alexislitvine opened this issue Oct 24, 2023 · 3 comments
Assignees

Comments

@alexislitvine
Copy link

alexislitvine commented Oct 24, 2023

An error message appears while saving a tile, making it impossible to save.

We tried on Safari, Firefox, and Edge - all with the same error message. Can you help @danrademacher @jeffreyameyer ?

Repro Steps

  1. Go to Project#28, e.g. tile#136
  2. Add a start date to the existing N7 road
  3. Try to save
  4. See error

**Screenshots **

image_2023_10_24T09_23_54_208Z
![image_2023_10_24T09_23_27_900Z](
Screenshot 2023-10-24 at 10 09 29
https://github.com/OpenHistoricalMap/issues/assets/94073388/e71104c1-f99b-4571-b516-eb33fd1435d9)

image_2023_10_24T09_23_27_900Z

@Rub21
Copy link

Rub21 commented Oct 25, 2023

hey @alexislitvine , thanks for reporting the issue!

I have been trying to recreate the issues, but it did not happen in my end, for my test I used Firefox and Safari!

My editions were in: Project #28, Task #136

image

I was able to save my changes!!

Note: Maybe the dates are not accurate, but I can update those according to the dates that you want to add. Also could you guide us through the process of recreating the issue maybe the dates that you are including, step by step?

cc. @batpad

@alexislitvine
Copy link
Author

Hi @Rub21 -- I have just found the culprit!! The issue was caused by someone editing the date of a very long segment that crossed multiple tiles at the same time. My edits could not be saved as the date for the segment in question had already been changed by another user and therefore should not be displayed any longer. Hence the 404-type error. Does that make sense?
Although this makes sense, it can be very annoying during a large mapping event when lots of users are editing at the same time. Could we by default cut all segments on tile boundaries to avoid this problem?

@Rub21
Copy link

Rub21 commented Oct 25, 2023

My edits could not be saved as the date for the segment in question had already been changed by another user and therefore should not be displayed any longer. Hence the 404-type error. Does that make sense?

Yes, your explanation makes sense. In openHistoricalMap's system, when you attempt to save edits, conflicts can arise if the data you're working with in memory is outdated due to recent modifications by another user. This version mismatch for specific objects is likely what triggers the 404-type error.

Could we by default cut all segments on tile boundaries to avoid this problem?

Automatically cutting road segments at tile boundaries isn't be posible for the current software, Only the mappers can decide if they want to break roads into smaller chunks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants