Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start Date and End Date fields should have structured input fields #644

Closed
1ec5 opened this issue Dec 5, 2023 · 1 comment · Fixed by OpenHistoricalMap/iD#185
Closed
Assignees

Comments

@1ec5
Copy link
Member

1ec5 commented Dec 5, 2023

iD’s Start Date and End Date fields are currently typed as date fields. Due to a fortunate bug, they wind up as ordinary text fields that accept the full range of years and allow months and days to be omitted: #563. But this still requires the user to be familiar with ISO 8601-esque syntax; otherwise, they’ll get yelled at by the validator, which isn’t a great experience. Worse, BCE dates aren’t super intuitive in ISO 8601; I’ve spotted start_dates that are off by one due to manual entry.

We should replace the single text field with a series of dropdowns and text fields, similar to what’s in the time slider for setting the date range:

Date range

While we’re at it, we should use the standard internationalization APIs to determine which order to show the subfields in and present a separate dropdown for the era, so the user doesn’t have to guess (probably wrongly) how negative years work: #626 (comment).

For users who need to copy-paste already ISO-formatted dates from other sources, there’s always the raw tag editor, which would remain the same.

@1ec5 1ec5 added the ID label Dec 5, 2023
@1ec5
Copy link
Member Author

1ec5 commented Dec 5, 2023

The roadheight field type similarly stuffs multiple HTML input fields and dropdowns into a single field. It would be a good model to follow for this enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant