Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in oic.utils.authn.client.get_client_id #445

Closed
ermakoves opened this issue Dec 4, 2017 · 3 comments
Closed

Bugs in oic.utils.authn.client.get_client_id #445

ermakoves opened this issue Dec 4, 2017 · 3 comments
Assignees
Milestone

Comments

@ermakoves
Copy link
Contributor

ermakoves commented Dec 4, 2017

  1. What is this for ?
    https://github.com/OpenIDC/pyoidc/blob/c0f82922d7239157db26a44d9f6768967e182baa/src/oic/utils/authn/client.py#L503
    None[key]

  2. https://github.com/OpenIDC/pyoidc/blob/c0f82922d7239157db26a44d9f6768967e182baa/src/oic/utils/authn/client.py#L526
    Does clients dictionary contains keys like token? I can't find usage like this.

@tpazderka
Copy link
Collaborator

Yes, most of the library is built on the assumption of dict-like behaviour. And registration access token is also stored as a key alongside with client ID.

@ermakoves
Copy link
Contributor Author

Yes, most of the library is built on the assumption of dict-like behaviour. And registration access token is also stored as a key alongside with client ID.

_cinfo[_bid] is pointless code

And if implement ClientDB, i should in some case return client_info and in some case only client id ? I think this is wrong

@tpazderka
Copy link
Collaborator

Ah, I can see your point now. It looks like an oversight when fixing handling of the unicode. That lie should probably should have been _cinfo = cdb[_bid].

For the second question, the code seems to return clientID in all cases.

@tpazderka tpazderka added this to the P2: SHOULD milestone Dec 6, 2017
@tpazderka tpazderka self-assigned this Dec 8, 2017
tpazderka added a commit that referenced this issue Dec 8, 2017
tpazderka added a commit that referenced this issue Dec 8, 2017
@rohe rohe closed this as completed in #453 Jan 12, 2018
andrewkrug pushed a commit to mozilla-iam/pyoidc that referenced this issue Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants