We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
By default requests does not use timeouts, so it can hang forever. Production code using requests should almost always specify a timeout. http://docs.python-requests.org/en/master/user/advanced/#timeouts
requests
I can subclass oic.oic.Client to forward a timeout for most of pyoidc requests usage:
oic.oic.Client
class Client(oic.oic.Client): def http_request(self, *args, **kwargs): # Set requests timeout for all http connections pyoidc makes kwargs["timeout"] = (3.05, 10) return super(Client, self).http_request(*args, **kwargs)
But pyoidc fetches keys without specifying any timeout or using the above Client to make the request, see KeyBundle.do_remote https://github.com/OpenIDC/pyoidc/blob/master/src/oic/utils/keyio.py#L168
KeyBundle.do_remote
The text was updated successfully, but these errors were encountered:
Add timeout kwarg to KeyBundle
4e7b9f2
This serves as a timeout for http connections through requests. Close #566
6fcf034
b8e9885
This serves as a timeout for http connections through requests. Close CZ-NIC#566
tpazderka
No branches or pull requests
By default
requests
does not use timeouts, so it can hang forever. Production code using requests should almost always specify a timeout.http://docs.python-requests.org/en/master/user/advanced/#timeouts
I can subclass
oic.oic.Client
to forward a timeout for most of pyoidc requests usage:But pyoidc fetches keys without specifying any timeout or using the above Client to make the request, see
KeyBundle.do_remote
https://github.com/OpenIDC/pyoidc/blob/master/src/oic/utils/keyio.py#L168
The text was updated successfully, but these errors were encountered: