Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbreak appveyor.yml after cryptography update #771

Merged
merged 1 commit into from Mar 15, 2021
Merged

Unbreak appveyor.yml after cryptography update #771

merged 1 commit into from Mar 15, 2021

Conversation

schlenk
Copy link
Collaborator

@schlenk schlenk commented Feb 10, 2021

Try upgrading pip first.

  • Any changes relevant to users are recorded in the CHANGELOG.md.
  • The documentation has been updated, if necessary.
  • New code is annotated.
  • Changes are covered by tests.

@schlenk
Update appveyor.yml
0bfb948 
Try upgrading pip first.
@schlenk schlenk changed the title Update appveyor.yml Unbreak appveyor.yml after cryptography update Feb 10, 2021
@schlenk schlenk marked this pull request as ready for review February 10, 2021 10:00
tpazderka
tpazderka reviewed Feb 11, 2021
View reviewed changes
Copy link
Collaborator

@tpazderka tpazderka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't a similar change be in travis config as well?

@schlenk
Copy link
Collaborator Author

schlenk commented Feb 12, 2021

Yes, travis CI might need similar things done. Not sure if it can use the prebuilt .whl files or if it needs a rust toolchain though. The 3.7 builds run, the 3.6 fail with the same pip version, so guess it is more than just upgrading pip for those.

@schlenk
Copy link
Collaborator Author

schlenk commented Mar 13, 2021

Should i just merge the appveyor part and we fix the travis stuff with the move to github actions?

tpazderka
tpazderka approved these changes Mar 15, 2021
View reviewed changes
Copy link
Collaborator

@tpazderka tpazderka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sure.

@schlenk schlenk merged commit eb19aec into master Mar 15, 2021
@schlenk schlenk deleted the fix-appveyor branch March 15, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpazderka tpazderka tpazderka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schlenk @tpazderka