Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oidn fails on very light shadows #33

Closed
Dade916 opened this issue Jun 6, 2019 · 2 comments
Closed

Oidn fails on very light shadows #33

Dade916 opened this issue Jun 6, 2019 · 2 comments

Comments

@Dade916
Copy link

Dade916 commented Jun 6, 2019

We have received some report of Oidn failing to denoise image area with very light shadow. It is like if there is a threshold under which noise is not removed.

This is an example of the problem, the normal rendering:

normal

and the is the Oidn output:

denoised

The very end of the monkey shadow is not denoised, there is a quite sharp cutoff.

This is a .zip with the .png/.exr rendering images, albedo and normal AOVs to replicate the problem:

img.zip

This is the thread in our forum where the problem is discussed: https://forums.luxcorerender.org/viewtopic.php?f=4&t=1122

From the above forum thread, another example of the problem in a real world scene can be seen here: https://forums.luxcorerender.org/viewtopic.php?f=4&t=1122&start=10#p13302

@atafra
Copy link
Collaborator

atafra commented Jun 6, 2019

Thanks for reporting this issue! We are currently preparing a new release, which will fix this. This is the produced output with the new version (not final yet):

denoised_new

@Dade916
Copy link
Author

Dade916 commented Jun 6, 2019

Thanks Attila, I guess we can close this.

@Dade916 Dade916 closed this as completed Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants