Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error: SwiftLint not installed, download from https://github.com/realm/SwiftLint #121

Closed
ProfDrLuigi opened this issue Jul 20, 2020 · 11 comments
Labels
bug Something isn't working

Comments

@ProfDrLuigi
Copy link
Contributor

ProfDrLuigi commented Jul 20, 2020

If I try to compile I get these error above.

@ErrorErrorError
Copy link
Collaborator

You need to install SwiftLint on your system before you can compile HeliPort. You can follow the link it shows you to install SwiftLint.

@Goshin Goshin closed this as completed Jul 20, 2020
@ProfDrLuigi
Copy link
Contributor Author

ProfDrLuigi commented Jul 20, 2020

Yes I know. I put it in "Podfile" and installed it. But ... error.

grafik
grafik
grafik

@ProfDrLuigi
Copy link
Contributor Author

ProfDrLuigi commented Jul 20, 2020

Yes I did. have a look at my Screenshots above. I compiled HeliPort every day again. But this time it stucks.

@ErrorErrorError
Copy link
Collaborator

ErrorErrorError commented Jul 20, 2020

Yes I did. have a look at my Screenshots above. I compiled HeliPort every day again. But this time it stucks.

Yup sorry I didn't see that picture until after I sent the previous message. There hasn't been anything that changed in HeliPort project with SwiftLint as far as I know. I used brew install SwiftLint methods so I can't really say as to why the pods aren't working, well in this case SwiftLint.

If you want you could try the brew method but HeliPort hasn't really changed anything regarding to scripts and SwiftLint.

@ProfDrLuigi
Copy link
Contributor Author

brew install did the trick. But I don´t understand why it was working the days before and now (nothing is changed) it stucks. But ok ... Problem solved. :)

@williambj1 williambj1 reopened this Jul 21, 2020
@williambj1 williambj1 added the bug Something isn't working label Jul 21, 2020
@Goshin
Copy link
Collaborator

Goshin commented Jul 21, 2020

SwiftLint should be installed as a global CLI tool via brew, otherwise, you need to add the executable path of the pod module into your PATH variable.

@ErrorErrorError
Copy link
Collaborator

SwiftLint should be installed as a global CLI tool via brew, otherwise, you need to add the executable path of the pod module into your PATH variable.

It could also be included in Podfile via pod 'SwiftLint' since now the latest master has a script that checks if SwiftLint is installed via CocoaPods, however I am not sure which would be the most recommended way if having in the command line or just for the project itself via CocoaPods.

@Goshin
Copy link
Collaborator

Goshin commented Jul 21, 2020

It could also be included in Podfile via pod 'SwiftLint' since now the latest master has a script that checks if SwiftLint is installed via CocoaPods,

sry but I don't see the check script?

@ErrorErrorError
Copy link
Collaborator

ErrorErrorError commented Jul 21, 2020

sry but I don't see the check script?

if which "${PODS_ROOT}/SwiftLint/swiftlint" >/dev/null; then 
    ${PODS_ROOT}/SwiftLint/swiftlint
elif which swiftlint >/dev/null; then
    swiftlint
else
  echo "warning: SwiftLint not installed, download from https://github.com/realm/SwiftLint"
fi

This script is in the latest commit 0222fae.

You can find it here:
Screen Shot 2020-07-21 at 2 32 47 AM

However it is not something you have to add, you can still use brew install swiftlint, it's just another option since you have to invoke pod install anyways to download the other dependencies.

@Goshin
Copy link
Collaborator

Goshin commented Jul 21, 2020

oops I didn't notice the latest commit, so it should fix the issue.

@williambj1
Copy link
Collaborator

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants