Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime downloading of piper voice model #176

Open
g3ar-v opened this issue Mar 28, 2024 · 6 comments
Open

runtime downloading of piper voice model #176

g3ar-v opened this issue Mar 28, 2024 · 6 comments

Comments

@g3ar-v
Copy link

g3ar-v commented Mar 28, 2024

Problem statement
From the codebase here, it seems new voice models can't be downloaded if piper already exists because the only time a voice model would be downloaded is if piper doesn't exist.

Solution
Check if the PIPER_VOICE file declared in .env exists in the piper directory. if not download it, if the link and name's are provided in .env

@g3ar-v
Copy link
Author

g3ar-v commented Mar 28, 2024

I have implemented a solution for this and I could create a pull request. If necessary.

@tyfiero
Copy link
Collaborator

tyfiero commented Mar 28, 2024

I just merged some changes that help with piper downloading, can you check to see if the latest merges fix the problem? If not please creat a pull request with your fix. Thanks!

@g3ar-v
Copy link
Author

g3ar-v commented Mar 28, 2024

Just checked it. The merge wouldn't. I'll go ahead with the pull request.

@andrewfr
Copy link

andrewfr commented May 5, 2024

@g3ar-v @tyfiero

I think it would help (including speed things up a bit) if the model (voice) was preloaded in the piper directory as a part of the installation.

@g3ar-v
Copy link
Author

g3ar-v commented May 6, 2024

Valid point, but I believe that the aim was to avoid a bloated codebase, so it wasn't done that way.

@andrewfr
Copy link

andrewfr commented May 6, 2024

@g3ar-v Okay. I don't consider the models the code base, per se. I've been writing small programs with Piper to get a feel for it. My sense is if you need a model, why not pre-install it, rather than install it upon set up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants