Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Image Viewer saves bloated fontimage.bar #425

Open
Vladabdf opened this issue Feb 14, 2021 · 7 comments
Open

[BUG] - Image Viewer saves bloated fontimage.bar #425

Vladabdf opened this issue Feb 14, 2021 · 7 comments
Labels
2/FM Kingdom Hearts 2 and Final Mix Enhancement Request for, or a pull request of, a new feature or enhancement to an existing one. GUI Tools Concerning OpenKH.Tools.* Not a Bug Looks like a bug, but it isn't

Comments

@Vladabdf
Copy link
Collaborator

Vladabdf commented Feb 14, 2021

OpenKH Build
Release 1393

OpenKH Program
OpenKh.Tools.ImageViewer

Describe the Bug
Upon saving an edited fontimage.bar file, the size is increased from 233kb to 425kb.

To Reproduce
Steps to reproduce the behavior:

  1. Open Image Viewer
  2. Replace one of the images in the file (in this case, sysfont, image index 0)
  3. Append 4-bpp change with pngquant enabled
  4. Save changed file

Expected behavior
File should be 233kb.

Additional context
I have verified through multiple attempts that the image size is 1:1 how it should be. In this case, 512x256, same as the unmodified fontimage file from the vanilla, untouched ISO. I will be including a zip with three files within:

  1. The modified png I wish to use
  2. The unmodified original bar file
  3. The saved bar file that I get upon going to File > Save
@Vladabdf Vladabdf added Bug Something is not working as intended, or at all. GUI Tools Concerning OpenKH.Tools.* labels Feb 14, 2021
@ghost ghost self-assigned this Feb 14, 2021
@ghost
Copy link

ghost commented Feb 14, 2021

Will look into this.

@ghost
Copy link

ghost commented Feb 14, 2021

Where is the ZIP file you said you would include?

@ghost ghost added the 2/FM Kingdom Hearts 2 and Final Mix label Feb 14, 2021
@Vladabdf
Copy link
Collaborator Author

msg.zip
I am an idiot and forgot to include this. Hee hee...

@ghost
Copy link

ghost commented Feb 14, 2021

Editing fontimage is not supported by the Image Editor yet. The issue you are having happens because the tool creates IMGD images instead of RAWBMP images.

We should address this somehow.

@ghost ghost added Not a Bug Looks like a bug, but it isn't Enhancement Request for, or a pull request of, a new feature or enhancement to an existing one. and removed Bug Something is not working as intended, or at all. labels Feb 14, 2021
@ghost
Copy link

ghost commented Feb 14, 2021

Tagged as 'not a bug' since it technically is not a bug.
It's just the lack of a feature.
I am too lazy to implement RAWBMP support, however. Someone else wanna take a gander?
If nobody does... anything in a week, I will do so.

@Vladabdf
Copy link
Collaborator Author

If nobody does... anything in a week, I will do so.

It has been over a week.

@ghost
Copy link

ghost commented Feb 24, 2021

If nobody does... anything in a week, I will do so.

It has been over a week.

Will be addressed in the AvaloniaUI builds. Please follow #441 for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2/FM Kingdom Hearts 2 and Final Mix Enhancement Request for, or a pull request of, a new feature or enhancement to an existing one. GUI Tools Concerning OpenKH.Tools.* Not a Bug Looks like a bug, but it isn't
Projects
None yet
Development

No branches or pull requests

1 participant