-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom ExperienceMaker #285
Comments
I think |
I had multiple different ones in mind, actually, for different projects. For instance:
Basically, anything that changes what the model does / how it interacts with the outside world, or how it is evaluated, would be implemented in the experience maker.
I agree! I only suggest it because the I could of course just monkey-patch the experience maker class, or maintain my own fork, so all of this isn't absolutely essential. But I think it might be useful for others to have this configurable as well. |
I think it's probably better this way Welcome to have related MR contributions~ |
OK! I'll test this on my side for a bit to make sure it covers all the use cases I have in mind. I'll open a PR in a couple of weeks. |
I have a use case where I'd like to use a custom
ExperienceMaker
class instead of either of the provided ones. As far as I can tell, there isn't currently a way to configure the experience maker class used byPPOTrainer
/ActorPPOTrainer
.Would you be open to a PR that makes this configurable?
And if yes, would the best way of doing this be to put it into the
DeepspeedStrategy
?The text was updated successfully, but these errors were encountered: